Change in libosmocore[master]: vty: Allow larger strlen parsing numerical range values

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 29 19:53:19 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19423 )

Change subject: vty: Allow larger strlen parsing numerical range values
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > well, the 64bit mask would only work on a 64bit arch, right?
> > 
> > Where do we need numeric values that large?
> 
> to express hex masks, like cpu-affinity mask. This allows for systems with up to 64 cores (we could thing about extending it to 128 if needed).

I would argue in favor of explicitly adding single CPU numbers to a set with one "add" per VTY line/command. Systems with 256 logical cores are not unheard of, 64 certainly isn't going to cut it even with hardware available to day.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id053acd6bf5e8fb7c468959f0b78b778f8c5e6c2
Gerrit-Change-Number: 19423
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 29 Jul 2020 19:53:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/084e5939/attachment.htm>


More information about the gerrit-log mailing list