Change in osmo-iuh[master]: Provide more context when logging "Error in ANY_fromType_aper"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 29 18:12:25 UTC 2020 

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/19446 )


Change subject: Provide more context when logging "Error in ANY_fromType_aper"
......................................................................

Provide more context when logging "Error in ANY_fromType_aper"

Let's add the type name whose encoding failed to give us some kind
of a clue what's happening in those situations.

Change-Id: I802677ba7164a4d3382d4bc00f5e1c7ab7067d89
---
M src/ranap_common.c
M src/rua_common.c
M src/sabp_common.c
3 files changed, 15 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/19446/1

diff --git a/src/ranap_common.c b/src/ranap_common.c
index 46203e0..4ada7ff 100644
--- a/src/ranap_common.c
+++ b/src/ranap_common.c
@@ -331,7 +331,7 @@
 	pdu.choice.initiatingMessage.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.initiatingMessage.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -358,7 +358,7 @@
 	pdu.choice.successfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.successfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -385,7 +385,7 @@
 	pdu.choice.unsuccessfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.unsuccessfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -412,7 +412,7 @@
 	pdu.choice.outcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.outcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -440,7 +440,7 @@
 
 	rc = ANY_fromType_aper(&buff->value, type, sptr);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", type->name);
 		FREEMEM(buff);
 		return NULL;
 	}
@@ -474,14 +474,14 @@
 
 	rc = ANY_fromType_aper(&buff->firstValue, type1, sptr1);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", type1->name);
 		FREEMEM(buff);
 		return NULL;
 	}
 
 	rc = ANY_fromType_aper(&buff->secondValue, type2, sptr2);
 	if (rc < 0) {
-		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRANAP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", type2->name);
 		ASN_STRUCT_FREE(asn_DEF_RANAP_ProtocolIE_FieldPair, buff);
 		return NULL;
 	}
diff --git a/src/rua_common.c b/src/rua_common.c
index 3c9d773..77ac591 100644
--- a/src/rua_common.c
+++ b/src/rua_common.c
@@ -140,7 +140,7 @@
 	pdu.choice.initiatingMessage.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.initiatingMessage.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -163,7 +163,7 @@
 	pdu.choice.successfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.successfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -186,7 +186,7 @@
 	pdu.choice.unsuccessfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.unsuccessfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -211,7 +211,7 @@
 
 	rc = ANY_fromType_aper(&buff->value, type, sptr);
 	if (rc < 0) {
-		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DRUA, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", type->name);
 		FREEMEM(buff);
 		return NULL;
 	}
diff --git a/src/sabp_common.c b/src/sabp_common.c
index cdb0e32..7aee4b7 100644
--- a/src/sabp_common.c
+++ b/src/sabp_common.c
@@ -114,7 +114,7 @@
 	pdu.choice.initiatingMessage.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.initiatingMessage.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -141,7 +141,7 @@
 	pdu.choice.successfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.successfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -168,7 +168,7 @@
 	pdu.choice.unsuccessfulOutcome.criticality = criticality;
 	rc = ANY_fromType_aper(&pdu.choice.unsuccessfulOutcome.value, td, sptr);
 	if (rc < 0) {
-		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", td->name);
 		return NULL;
 	}
 
@@ -195,7 +195,7 @@
 
 	rc = ANY_fromType_aper(&buff->value, type, sptr);
 	if (rc < 0) {
-		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper\n");
+		LOGP(DSABP, LOGL_ERROR, "Error in ANY_fromType_aper (%s)\n", type->name);
 		FREEMEM(buff);
 		return NULL;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/19446
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I802677ba7164a4d3382d4bc00f5e1c7ab7067d89
Gerrit-Change-Number: 19446
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/e1a5dce4/attachment.htm>

More information about the gerrit-log mailing list