Change in osmo-msc[master]: vty: fix vsub reference counting: call vlr_subscr_put()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 29 12:54:43 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19427 )

Change subject: vty: fix vsub reference counting: call vlr_subscr_put()
......................................................................

vty: fix vsub reference counting: call vlr_subscr_put()

Otherwise, each time the 3GPP TS 44.014 MS test commands (TCH loop)
are invoked, both subscriber_mstest_{close,open} functions add +1
to the subscriber's reference count, but never revoke it.

Change-Id: I0cefa5b5a0cb712080ba2afd322db329f19608e3
---
M src/libmsc/msc_vty.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  Hoernchen: Looks good to me, approved; Verified
  Jenkins Builder: Verified



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index c5e93aa..07a88c2 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -1704,6 +1704,7 @@
 
 	gsm0414_tx_close_tch_loop_cmd(msc_a, loop_mode);
 
+	vlr_subscr_put(vsub, VSUB_USE_VTY);
 	return CMD_SUCCESS;
 }
 
@@ -1732,6 +1733,7 @@
 
 	gsm0414_tx_open_loop_cmd(msc_a);
 
+	vlr_subscr_put(vsub, VSUB_USE_VTY);
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19427
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0cefa5b5a0cb712080ba2afd322db329f19608e3
Gerrit-Change-Number: 19427
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/86d10f1f/attachment.htm>


More information about the gerrit-log mailing list