Change in libosmocore[master]: osmo_sock_init2: improve support for AF_UNSPEC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jul 29 11:42:10 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19140 )

Change subject: osmo_sock_init2: improve support for AF_UNSPEC
......................................................................


Patch Set 7:

(1 comment)

If I'm wrong please if possible improve that comment.

https://gerrit.osmocom.org/c/libosmocore/+/19140/7/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/19140/7/src/socket.c@386 
PS7, Line 386: 			/* When called with AF_UNSPEC, family will set to IPv4 or IPv6 */
I think I don't get this comment + if clause. IIUC ig family=AF_UNSPEC is passed, no result in rp will match AF_UNSPEC; because all will be either AF_INET or AF_INET6.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19140
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I397c633931fd00d4f083955a3c49a40fb002d766
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jul 2020 11:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/8e65aabe/attachment.htm>


More information about the gerrit-log mailing list