Change in osmo-sgsn[master]: Send a BVC-RESET to all persistent Gb interfaces at start-up

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 29 09:12:30 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/19027 )

Change subject: Send a BVC-RESET to all persistent Gb interfaces at start-up
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

> Patch Set 4:
> 
> The SGSN could react on S_NS_UNBLOCK signal and check if the NSVC is persistant. We should ensure we don't reset a running BSVC.

The S_NS_UNBLOCK is only used on Frame Relay or on non-spec-compliant "IPA style" Gb/IP.  Spec-compliant Gb/IP doesn't use the NS-RESET/BLOCK/UNBLOCK procedures, so this event is never received.

I am very much inclined to merge this patch as it fixes an annoying deadlock occurring in the real world at a customer installation.

https://gerrit.osmocom.org/c/osmo-sgsn/+/19027/4/src/sgsn/sgsn_main.c 
File src/sgsn/sgsn_main.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/19027/4/src/sgsn/sgsn_main.c@215 
PS4, Line 215: 		nsvc->state |= NSE_S_ALIVE;
> we shouldn't sent messages over dead nsvc's
The problem is that with the specific BSS I'm talking to, the only way to make the link active again is to send a BVC-RESET.

Basically it's stuck in an indefinite loop of:

Jul 29 11:00:08 osmo-cn osmo-sgsn[1409]: <0010> gprs_bssgp.c:1099 NSEI=1000/BVCI=100 Rejecting PDU type BVC-UNBLOCK for unknown BVCI
Jul 29 11:00:08 osmo-cn osmo-sgsn[1409]: <0010> gprs_bssgp_util.c:237 BSSGP BVCI=100 Tx STATUS, cause=Unknown BVCI

The BSS is ignoring that STATUS and the only way to recover after a SGSN restart is to send the BVC-RESET.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/19027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0b46035b40709c38bb9ab9493c11031a577e3ee0
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jul 2020 09:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/d4ed02f9/attachment.htm>


More information about the gerrit-log mailing list