Change in osmo-bts[master]: pcuif_proto: version 0xa: add support for NSVC IPv6 support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 28 13:10:15 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19418 )

Change subject: pcuif_proto: version 0xa: add support for NSVC IPv6 support
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/19418/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/19418/1//COMMIT_MSG@11 
PS1, Line 11: IPPROTO_IPIP is used for IPv4, IPPROTO_IPV6 for IPv6. 0 means unset or
This doesn't make sense to me, you are using something from the wrong layer afaiu. That's for stuff on top of IP(v4 or v6), while in here we need to specify IPv4 or IPv6 themselves.


https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h 
File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h@160 
PS1, Line 160: 	 * OS dependent. IPIP => v4, IPV6 => v6, 0 => unused */
So what? it goes over unix sockets, so same host/system on both sides...


https://gerrit.osmocom.org/c/osmo-bts/+/19418/1/include/osmo-bts/pcuif_proto.h@163 
PS1, Line 163: 		struct in_addr ipv4;
simply call the fields v4 and v6? So you have remote_ip.v6 ... Same as we do in in46_addr in libgtp.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4067b1af041b2cdad60d6fb16c9caee98bc218dd
Gerrit-Change-Number: 19418
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jul 2020 13:10:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200728/25039f2e/attachment.htm>


More information about the gerrit-log mailing list