Change in libosmocore[master]: socket.c: introduce osmo_sock_init3 & osmo_sock_init3_ofd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Jul 28 10:50:38 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 )

Change subject: socket.c: introduce osmo_sock_init3 & osmo_sock_init3_ofd
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@870 
PS2, Line 870: 	if (sfd < 0)
see here


https://gerrit.osmocom.org/c/libosmocore/+/19143/2/src/socket.c@931 
PS2, Line 931: 	return osmo_fd_init_ofd(ofd, osmo_sock_init3(type, proto, local, remote, flags));
> Ack
It's not a problem, if osmo_sock_init3() fails, osmo_fd_init_ofd() will return immediately. It's the same as in osmo_sock_init2().



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794
Gerrit-Change-Number: 19143
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 28 Jul 2020 10:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200728/1802ee2d/attachment.htm>


More information about the gerrit-log mailing list