Change in osmo-sgsn[master]: Send a BVC-RESET to all persistent Gb interfaces at start-up

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jul 27 14:47:17 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/19027 )

Change subject: Send a BVC-RESET to all persistent Gb interfaces at start-up
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/19027/3/src/sgsn/sgsn_main.c 
File src/sgsn/sgsn_main.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/19027/3/src/sgsn/sgsn_main.c@215 
PS3, Line 215: 		nsvc->state |= NSE_S_ALIVE;
> This looks like a hack. […]
I think the very notion of a "persistent" NS-VC is that it doesn't use the ALIVE/BLOCK/UNBLOCK procedure. We are sending a RESET to reset state, not because we cannot send data over it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/19027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0b46035b40709c38bb9ab9493c11031a577e3ee0
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Jul 2020 14:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200727/70dad9e0/attachment.htm>


More information about the gerrit-log mailing list