This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19400 ) Change subject: trx_toolkit/data_if.py: do not validate TRXD message twice ...................................................................... trx_toolkit/data_if.py: do not validate TRXD message twice DATAMSG.gen_msg() does validete the message before encoding. Change-Id: Ia3691b3c18778cf7a1f16c71bef5c0b2e6241190 Related: OS#4681 --- M src/target/trx_toolkit/data_if.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 18e53ed..b1b1ecb 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -105,10 +105,7 @@ return msg def send_msg(self, msg, legacy = False): - # Validate a message - msg.validate() - - # Generate TRX message + # Validate and encode TRXD message payload = msg.gen_msg(legacy) # Send message -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia3691b3c18778cf7a1f16c71bef5c0b2e6241190 Gerrit-Change-Number: 19400 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200726/be07cd78/attachment.htm>