This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 ) Change subject: bsc: test RR Channel Release EARFCNs ...................................................................... Patch Set 3: (4 comments) Sorry for not sending all warnings at once, didn't have time to do more detailed review. In general, I am ok with this change, but I don't like that instead of introducing a separate test case for (RR) Channel Release EARFCNs, you're integrating more checks into the existing tests. I suggest to make f_expect_chan_rel() return the received Channel Release message (instead of overloading it with even more functionality), and introduce a separate test case verifying the EARFCN list it contains. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/3/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/3/bsc/BSC_Tests.ttcn@1463 PS3, Line 1463: ispresent I think you should use istemplatekind(csfb_expect_cells, "omit") here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/3/bsc/BSC_Tests.ttcn@1472 PS3, Line 1472: ws https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/3/bsc/BSC_Tests.ttcn@1774 PS3, Line 1774: ispresent Same here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/3/bsc/BSC_Tests.ttcn@1794 PS3, Line 1794: ws -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I882c5e1f70bcc4833fc837a95c900ce291919cc5 Gerrit-Change-Number: 19216 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 26 Jul 2020 20:28:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200726/709c6c81/attachment.htm>