This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19381 ) Change subject: i460_mux: correctly re-initalize when deleting subchannels ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19381/1/src/gsm/i460_mux.c File src/gsm/i460_mux.c: https://gerrit.osmocom.org/c/libosmocore/+/19381/1/src/gsm/i460_mux.c@361 PS1, Line 361: schan->rate = OSMO_I460_RATE_NONE; to be honest, in indsight, I don't even understand why we memset the entire sub-channel here. Particularly also the bit buffer allocated above by alloc_bitbuf() in line 346 cannot simply be memset() over - this creates a memory leak. Also, imagine there are some entries left in the mux.tx_queue. We simply leak that memory if we re-initialize the LLIST_HEAD here. I think we need to be more intelligent with clenaup here, i.e. * iterate over tx_queue enties and free them, * release the demux bit buffer * whatever else cleanup that might be related. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I937a9d4db95f44a860cd2c5dbb660dc1970b9a49 Gerrit-Change-Number: 19381 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 25 Jul 2020 20:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200725/508ab90e/attachment.htm>