Change in osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types: fix length field in GprsMobileAllication

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19369 )

Change subject: library/RLCMAC_CSN1_Types: fix length field in GprsMobileAllication
......................................................................

library/RLCMAC_CSN1_Types: fix length field in GprsMobileAllication

  - Length of field 'MA_BITMAP' is specified in bits, not bytes;
  - The value range of field MA_LENGTH is 0..63, therefore:
    - value  0 means that field 'MA_BITMAP' is  1 bit long,
    - value  1 means that field 'MA_BITMAP' is  2 bits long,
    - value 63 means that field 'MA_BITMAP' is 64 bits long.

Change-Id: Iec19da18637febfa15bc09175bc51504c721c42f
Related: SYS#4868, OS#4547
---
M library/RLCMAC_CSN1_Types.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn
index 6bdca40..cc1ae22 100644
--- a/library/RLCMAC_CSN1_Types.ttcn
+++ b/library/RLCMAC_CSN1_Types.ttcn
@@ -807,13 +807,13 @@
 		RflNumberList		rfl_number_list optional,
 		BIT1			ma_present,
 		uint6_t			ma_length optional,
-		bitstring		ma_bitmap optional
+		bitstring		ma_bitmap length(1..64) optional
 		/* TODO: ARFCN index list */
 	} with {
 		variant (rfl_number_list) "PRESENCE(rfl_number_list_present = '1'B)"
 		variant (ma_length) "PRESENCE(ma_present = '0'B)"
 		variant (ma_bitmap) "PRESENCE(ma_present = '0'B)"
-		variant (ma_length) "LENGTHTO(ma_bitmap)+1"
+		variant (ma_length) "LENGTHTO(ma_bitmap)-1, UNIT(bits)"
 		variant (ma_bitmap) "BYTEORDER(first), BITORDER(msb)"
 	};
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec19da18637febfa15bc09175bc51504c721c42f
Gerrit-Change-Number: 19369
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200723/ad42887c/attachment.htm>