Change in osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types: make use of 'LENGTHTO(...)+N' syntax

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 21 16:14:20 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19338 )

Change subject: library/RLCMAC_CSN1_Types: make use of 'LENGTHTO(...)+N' syntax
......................................................................

library/RLCMAC_CSN1_Types: make use of 'LENGTHTO(...)+N' syntax

Thanks to LaF0rge, this syntax is now supported by TITAN.

Change-Id: I16ddc3e9f57dffba3e0f2ea80eeb63be3468da06
Related: SYS#4868, OS#4547
---
M library/RLCMAC_CSN1_Types.ttcn
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn
index 20c2d81..a14577a 100644
--- a/library/RLCMAC_CSN1_Types.ttcn
+++ b/library/RLCMAC_CSN1_Types.ttcn
@@ -757,9 +757,7 @@
 		uint4_t			ma_freq_len,
 		octetstring		m1_freq_list
 	} with {
-		/* FIXME: this can not be expressed in TTCN-3 ?!? */
-		//variant (ma_freq_len) "LENGTHTO(m1_freq_list)+3"
-		variant (ma_freq_len) "LENGTHTO(m1_freq_list)"
+		variant (ma_freq_len) "LENGTHTO(m1_freq_list)+3"
 	};
 	type record FrequencyParameters {
 		uint3_t			tsc,
@@ -801,9 +799,7 @@
 		variant (rfl_number_list) "PRESENCE(rfl_number_list_present = '1'B)"
 		variant (ma_length) "PRESENCE(ma_present = '0'B)"
 		variant (ma_bitmap) "PRESENCE(ma_present = '0'B)"
-		/* FIXME: this can not be expressed in TTCN-3 ?!? */
-		//variant (ma_length) "LENGTHTO(ma_bitmap)+1"
-		variant (ma_length) "LENGTHTO(ma_bitmap)"
+		variant (ma_length) "LENGTHTO(ma_bitmap)+1"
 	}
 
 	/* 12.11 Packet Request Reference */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I16ddc3e9f57dffba3e0f2ea80eeb63be3468da06
Gerrit-Change-Number: 19338
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/94f88e95/attachment.htm>


More information about the gerrit-log mailing list