Change in osmo-bsc[master]: Introduce support for ACC subset rotation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 21 16:09:01 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19303 )

Change subject: Introduce support for ACC subset rotation
......................................................................


Patch Set 3:

(6 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc 
File doc/manuals/chapters/bts.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc@428 
PS3, Line 428: allowing only ACCs 0-4 to connect to the BTS should reduce its load by 50%.
may be worth explicitly noticing "at the expense of not serving 50% of the subscribers"..


https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc@435 
PS3, Line 435: First level of management consists of an access list to flag specific ACCs as
The first level... IMHO


https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc@451 
PS3, Line 451: permanently
             : allowed ACCs (hence restrict the amount of mobile stations allowed to reach the
             : BTS). However, doing so on a permanent basis would be unfair to mobile 
it's confusing that we resetrict the amount of _permanently_ allowed ACCs but doing so on a _permanent_ basis is unfair.  Please re-word. Maybe simply remove the first _permanently_.


https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc@456 
PS3, Line 456: mobile stations
probably nit-picking, but as it is a SIM property I would write 'subscribers'.


https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/doc/manuals/chapters/bts.adoc@470 
PS3, Line 470: Furthermore, smaller cells with lots of subscribers may become overwhelmed with
even large cells.  I think "cells with large number of subscribers and limited overlappign coverage may become overwhelmed with traffic after the cell starts brodascasting"


https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/include/osmocom/bsc/acc.h 
File include/osmocom/bsc/acc.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/19303/3/include/osmocom/bsc/acc.h@38 
PS3, Line 38: len_allowed_adm
qty / quantity / count would be more obvious than 'len', IMHO. But only change if you agree. Not a request to change, just a thought.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I952c9eeae02809c7184078c655574ec817902e06
Gerrit-Change-Number: 19303
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 21 Jul 2020 16:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/b37e6d28/attachment.htm>


More information about the gerrit-log mailing list