Change in libosmocore[master]: pkgconfig/osmocodec/osmocoding: link to talloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Tue Jul 21 09:34:43 UTC 2020


Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19347 )

Change subject: pkgconfig/osmocodec/osmocoding: link to talloc
......................................................................

pkgconfig/osmocodec/osmocoding: link to talloc

find . -maxdepth 1 -iname "libosmo*so" | xargs -n1 -I\# sh -c "echo \#
&& nm \# | grep 'U talloc'"
tells us that all libs depend on talloc, but pkgconfig omits it for
codec and coding, which sometimes leads to linking issues with libtool
and
lld.

Change-Id: I75a4d39a0c3d53fc4c311e25e933a22832616cea
---
M libosmocodec.pc.in
M libosmocoding.pc.in
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/libosmocodec.pc.in b/libosmocodec.pc.in
index 3030230..9e058ef 100644
--- a/libosmocodec.pc.in
+++ b/libosmocodec.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom Codec related utilities Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} -losmocodec
-Cflags: -I${includedir}/
+Libs: -L${libdir} @TALLOC_LIBS@ -losmocodec
+Cflags: -I${includedir}/ @TALLOC_CFLAGS@
 
diff --git a/libosmocoding.pc.in b/libosmocoding.pc.in
index 580b170..d1d03c4 100644
--- a/libosmocoding.pc.in
+++ b/libosmocoding.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom L1 transcoding Library
 Description: C Utility Library
 Version: @VERSION@
-Libs: -L${libdir} -losmocoding -losmocodec -losmogsm -losmocore
-Cflags: -I${includedir}/
+Libs: -L${libdir} @TALLOC_LIBS@ -losmocoding -losmocodec -losmogsm -losmocore
+Cflags: -I${includedir}/ @TALLOC_CFLAGS@
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I75a4d39a0c3d53fc4c311e25e933a22832616cea
Gerrit-Change-Number: 19347
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/0543507e/attachment.htm>


More information about the gerrit-log mailing list