Change in libosmocore[master]: logging: Avoid printing OSMO_LOGCOLOR_END if no color was used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 21 09:26:03 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19336 )

Change subject: logging: Avoid printing OSMO_LOGCOLOR_END if no color was used
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> that patch in osmo-bts.git is from today.  Merging this will cause all older osmo-trx versions to fail passing 'make check' against modern libosmocore versions.
> 
> I agree your patch is correct, but I don't want to create even more failures of https://jenkins.osmocom.org/jenkins/job/Osmocom-build-tags-against-master/

I agree with your rationale, but I think we should still get it fixed (to avoid more future issues), given that it only affects 1 project.

My proposal: Do a patch release for osmo-bts on top of latest release with the osmo-bts patch fixing the test so this way last release still works with both new and old libosmocore. Agree?


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie38cc639d7f4acd908f357e5bfb3ced07147583e
Gerrit-Change-Number: 19336
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jul 2020 09:26:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200721/abfa072c/attachment.htm>


More information about the gerrit-log mailing list