Change in osmo-pcu[master]: encoding: drop log_alert_exit(), use OSMO_ASSERT() instead

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jul 18 13:48:03 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19309 )


Change subject: encoding: drop log_alert_exit(), use OSMO_ASSERT() instead
......................................................................

encoding: drop log_alert_exit(), use OSMO_ASSERT() instead

Change-Id: Id5ef1c3c08dc7f264ad801e519d727d86f5ae5b8
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/09/19309/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index 92944f0..2564575 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -433,13 +433,6 @@
 	return plen;
 }
 
-static inline void log_alert_exit(const char * error)
-{
-	LOGP(DRLCMACUL, LOGL_ERROR, "%s", error);
-	pcu_tx_txt_ind(PCU_OML_ALERT, error);
-	exit(1);
-}
-
 /*
  * Immediate assignment, sent on the CCCH/AGCH
  * see GSM 04.08, 9.1.18 and GSM 44.018, 9.1.18 + 10.5.2.16
@@ -494,9 +487,7 @@
 	// A zero-length LV.  Just write L=0.
 	bitvec_write_field(dest, &wp,0,8);
 
-	if ((wp % 8))
-		log_alert_exit("Length of IMM.ASS without rest octets is not "
-			       "multiple of 8 bits, PLEASE FIX!\n");
+	OSMO_ASSERT(wp % 8 == 0);
 
 	plen = wp / 8;
 
@@ -748,9 +739,7 @@
 	bitvec_set_bytes(dest, mi, mi_len);        // Mobile Identity
 	wp += mi_len * 8;
 
-	if ((wp % 8))
-		log_alert_exit("Length of PAG.REQ without rest octets is not "
-			       "multiple of 8 bits, PLEASE FIX!\n");
+	OSMO_ASSERT(wp % 8 == 0);
 
 	plen = wp / 8;
 	bitvec_write_field(dest, &wp,0x0,1); // "L" Notification List Number; NLN(PCH) = off

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id5ef1c3c08dc7f264ad801e519d727d86f5ae5b8
Gerrit-Change-Number: 19309
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200718/8be23905/attachment.htm>


More information about the gerrit-log mailing list