Change in osmo-mgw[master]: refactor: use msgb to receive, pass and send RTP packets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jul 17 09:17:14 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18913 )

Change subject: refactor: use msgb to receive, pass and send RTP packets
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

I have tested it with TTCN3 and current master, it works fine. We should merge it as soon as possible. Apart from that I did not touch the passing of RTP packets much yet, so if there are problems they will be minimal.

https://gerrit.osmocom.org/c/osmo-mgw/+/18913/4/include/osmocom/mgcp/mgcp_internal.h 
File include/osmocom/mgcp/mgcp_internal.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/18913/4/include/osmocom/mgcp/mgcp_internal.h@35 
PS4, Line 35: /* FIXME: This this is only needed to compile the currently
The constants CONN_ID_BTS, CONN_ID_NET are removed in earlier patches.


https://gerrit.osmocom.org/c/osmo-mgw/+/18913/4/include/osmocom/mgcp/mgcp_internal.h@39 
PS4, Line 39: 
LOGPCONN in mgcp_conn.h does not work? Move this to mgcp_conn.h?

(In the long run we should try to eliminate mgcp_internal.h and move the parts to the related modules.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18913
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3af40b63bc49f8636d4e7ea2f8f83bb67f6619ee
Gerrit-Change-Number: 18913
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Jul 2020 09:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200717/4fc77c42/attachment.htm>


More information about the gerrit-log mailing list