Change in osmo-bsc[master]: propagate RSL error cause codes to RR Channel Release cause

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 16 12:03:21 UTC 2020 

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19215 )

Change subject: propagate RSL error cause codes to RR Channel Release cause
......................................................................

propagate RSL error cause codes to RR Channel Release cause

In various places that receive an error cause from RSL and place it in
lchan.release.rsl_error_cause, translate it to an RR cause and place that in
the recently added lchan.release.rr_cause. Hence the RR Channel Release message
now reflects more specific error causes when the reason for the error was
received in an RSL message's cause value.

Change-Id: I46eb12c91a8c08162b43dd22c7ba825ef3bbc6ac
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/lchan_fsm.c
4 files changed, 34 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 43d7040..c357981 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1898,5 +1898,6 @@
 bool trx_has_valid_pchan_config(const struct gsm_bts_trx *trx);
 
 enum gsm48_rr_cause bsc_gsm48_rr_cause_from_gsm0808_cause(enum gsm0808_cause c);
+enum gsm48_rr_cause bsc_gsm48_rr_cause_from_rsl_cause(uint8_t c);
 
 #endif /* _GSM_DATA_H */
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 0ed6715..72f2474 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -783,6 +783,8 @@
 		if (conn->lchan) {
 			conn->lchan->release.in_error = true;
 			conn->lchan->release.rsl_error_cause = data ? *(uint8_t*)data : RSL_ERR_IE_ERROR;
+			conn->lchan->release.rr_cause =
+				bsc_gsm48_rr_cause_from_rsl_cause(conn->lchan->release.rsl_error_cause);
 		}
 		gscon_bssmap_clear(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE);
 		break;
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 860e236..a4f6b7f 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -1867,3 +1867,29 @@
 		return GSM48_RR_CAUSE_ABNORMAL_UNSPEC;
 	}
 }
+
+/* Map RSL_ERR_* cause codes to gsm48_rr_cause codes.
+ * The mappings were chosen by naive guessing without a proper specification available. */
+enum gsm48_rr_cause bsc_gsm48_rr_cause_from_rsl_cause(uint8_t c)
+{
+	switch (c) {
+	case RSL_ERR_NORMAL_UNSPEC:
+		return GSM48_RR_CAUSE_NORMAL;
+	case RSL_ERR_MAND_IE_ERROR:
+		return GSM48_RR_CAUSE_INVALID_MAND_INF;
+	case RSL_ERR_OPT_IE_ERROR:
+		return GSM48_RR_CAUSE_COND_IE_ERROR;
+	case RSL_ERR_INVALID_MESSAGE:
+	case RSL_ERR_MSG_DISCR:
+	case RSL_ERR_MSG_TYPE:
+	case RSL_ERR_MSG_SEQ:
+	case RSL_ERR_IE_ERROR:
+	case RSL_ERR_IE_NONEXIST:
+	case RSL_ERR_IE_LENGTH:
+	case RSL_ERR_IE_CONTENT:
+	case RSL_ERR_PROTO:
+		return GSM48_RR_CAUSE_PROT_ERROR_UNSPC;
+	default:
+		return GSM48_RR_CAUSE_ABNORMAL_UNSPEC;
+	}
+}
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index dfb8a05..bcf7c4b 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -681,6 +681,7 @@
 		if (data) {
 			uint32_t next_state;
 			lchan->release.rsl_error_cause = *(uint8_t*)data;
+			lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
 			lchan->release.in_error = true;
 			if (lchan->release.rsl_error_cause != RSL_ERR_RCH_ALR_ACTV_ALLOC)
 				next_state = LCHAN_ST_BORKEN;
@@ -693,6 +694,7 @@
 				      rsl_err_name(lchan->release.rsl_error_cause), lchan->release.rsl_error_cause);
 		} else {
 			lchan->release.rsl_error_cause = RSL_ERR_IE_NONEXIST;
+			lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
 			lchan->release.in_error = true;
 			lchan_fail_to(LCHAN_ST_BORKEN, "Chan Activ NACK without cause IE");
 		}
@@ -1109,6 +1111,7 @@
 		osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN], 1);
 		lchan->release.in_error = true;
 		lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
+		lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
 		lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK);
 		return;
 
@@ -1125,6 +1128,7 @@
 		osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN], 1);
 		lchan->release.in_error = true;
 		lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
+		lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
 		lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);
 		/* TODO: we used to do this only for sysmobts:
 			int do_free = is_sysmobts_v2(ts->trx->bts);
@@ -1353,6 +1357,7 @@
 	default:
 		lchan->release.in_error = true;
 		lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
+		lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
 		lchan_fail("Timeout");
 		return 0;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19215
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I46eb12c91a8c08162b43dd22c7ba825ef3bbc6ac
Gerrit-Change-Number: 19215
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200716/c6a653a9/attachment.htm>

More information about the gerrit-log mailing list