Change in osmo-e1d[master]: actually implement the superchannel mode

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 14 16:58:57 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19231 )

Change subject: actually implement the superchannel mode
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-e1d/+/19231/5/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19231/5/src/intf_line.c@287 
PS5, Line 287: 			buf[tsn+(i*32)] = buf_ts[i];
> would be great having all these 32 defined somewhere.
yes, that was one of my thoughts, too.  However, it's actually not all too bad to read.  And the new code follows the existing style.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Id340b1925471f427deb6cda7eb54e80dfc71faec
Gerrit-Change-Number: 19231
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 16:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200714/afeccd81/attachment.htm>


More information about the gerrit-log mailing list