Change in osmocom-bb[master]: trx_toolkit/transceiver.py: implement the transmit burst queue

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jul 14 10:32:50 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19228 )

Change subject: trx_toolkit/transceiver.py: implement the transmit burst queue
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py 
File src/target/trx_toolkit/transceiver.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py@277 
PS2, Line 277: 		if event == "POWEROFF":
> Aren't yo repeating the same above in POWEROFF?
Above is for the child Transceiver instances (additional transceivers in a multi-trx setup), this call is for the current (parent) transceiver.


https://gerrit.osmocom.org/c/osmocom-bb/+/19228/2/src/target/trx_toolkit/transceiver.py@326 
PS2, Line 326: 			self._tx_queue.append(msg)
> If you sort them here when adding them, then during clk_tick you only need to check for the few firs […]
I was thinking about that, but then decided against this approach. Doing sorted insertion is probably more expensive than doing a full list iteration in self.clck_tick(). Python seems to have a sorted queue implementation, but it does not work with anything else than numbers (while we basically need to sort DATAMSG objects). Sigh.

At least for now, we can merge it as is and then optimize further.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19228
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66ef9667dc8d156ad578ce324941a816c07c105
Gerrit-Change-Number: 19228
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jul 2020 10:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200714/8f7c701f/attachment.htm>


More information about the gerrit-log mailing list