This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19156 ) Change subject: common: Avoid changing OPSTATE to Enabled upon RSL up ...................................................................... common: Avoid changing OPSTATE to Enabled upon RSL up the RSL link has nothing to do regarding the state of the Radio Carrier, as in it being up is not enough to have a working (enabled) Radio Carrier. Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678 --- M src/common/bts_trx.c 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/bts_trx.c b/src/common/bts_trx.c index 15640c6..6318dbc 100644 --- a/src/common/bts_trx.c +++ b/src/common/bts_trx.c @@ -153,13 +153,10 @@ int trx_link_estab(struct gsm_bts_trx *trx) { struct e1inp_sign_link *link = trx->rsl_link; - uint8_t radio_state = link ? NM_OPSTATE_ENABLED : NM_OPSTATE_DISABLED; int rc; - LOGP(DSUM, LOGL_INFO, "RSL link (TRX %02x) state changed to %s, sending Status'.\n", - trx->nr, link ? "up" : "down"); - - oml_mo_state_chg(&trx->mo, radio_state, NM_AVSTATE_OK); + LOGPTRX(trx, DSUM, LOGL_INFO, "RSL link %s\n", + link ? "up" : "down"); if (link) rc = rsl_tx_rf_res(trx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iefb5c4e1097233b5c31e4d621c544d51516af678 Gerrit-Change-Number: 19156 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200714/ec271dd9/attachment.htm>