This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19155 ) Change subject: bts-trx: Don't set OPSTATE enabled during trx_init ...................................................................... bts-trx: Don't set OPSTATE enabled during trx_init At that time we schedule a POWERON command towards osmo-trx, so let the callback of RSP POWERON set the OPSTATE in l1if_poweronoff_cb rather than setting it without waiting for confirmation from osmo-trx. Change-Id: Ib36a073cae5e1522821a04d8806648562f4e0f5b --- M src/osmo-bts-trx/l1_if.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 4cdb108..f47fc05 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -406,9 +406,6 @@ if (trx == trx->bts->c0) lchan_init_lapdm(&trx->ts[0].lchan[CCCH_LCHAN]); - /* Set to Operational State: Enabled */ - oml_mo_state_chg(&trx->mo, NM_OPSTATE_ENABLED, NM_AVSTATE_OK); - /* Send OPSTART ack */ return oml_mo_opstart_ack(&trx->mo); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib36a073cae5e1522821a04d8806648562f4e0f5b Gerrit-Change-Number: 19155 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200714/4f9cdd10/attachment.htm>