Change in osmo-e1d[master]: Use SOCK_STREAM sockets for E1_TS_MODE_RAW

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jul 11 13:56:05 UTC 2020


Hello tnt, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-e1d/+/19220

to look at the new patch set (#2).

Change subject: Use SOCK_STREAM sockets for E1_TS_MODE_RAW
......................................................................

Use SOCK_STREAM sockets for E1_TS_MODE_RAW

SEQPACKET is great for preserving message boundaries on signaling
channels that use HDLC.  However, its semantics, particularly regarding
truncation, are sub-optimal for RAW slots containing raw user
bitstreams (typically TRAU frames or PCM audio data).

So let's use SOCK_STREAM for RAW and keep SEQPACKET for HDLCFCS.

Closes: OS#4663
Change-Id: I1767ceaa5d2a008db0009b8027667a71c0fdc0f1
---
M src/ctl.c
M src/intf_line.c
2 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/20/19220/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I1767ceaa5d2a008db0009b8027667a71c0fdc0f1
Gerrit-Change-Number: 19220
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200711/d6ae5843/attachment.htm>


More information about the gerrit-log mailing list