Change in osmo-msc[master]: Clear Command: set cause value to "Call Control"

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/19213 )


Change subject: Clear Command: set cause value to "Call Control"
......................................................................

Clear Command: set cause value to "Call Control"

So far, by failing to initialize the cause value, we always send a Clear
Command cause == 0, which actually means "Radio Interface Message Failure".
This is seen in all my logged network traces of osmo-msc lab testing.

"Call Control" seems to be the only cause value that remotely fits a normal
release procedure, even if it was not voice call related.

Related: OS#4664
Change-Id: I1347ed72ae7d7ea73a557b866e764819c5ef8c42
---
M src/libmsc/msc_a.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/13/19213/1

diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c
index 76c0f01..0645c54 100644
--- a/src/libmsc/msc_a.c
+++ b/src/libmsc/msc_a.c
@@ -779,6 +779,9 @@
 		struct ran_msg msg = {
 			.msg_type = RAN_MSG_CLEAR_COMMAND,
 			.clear_command = {
+				/* "Call Control" is the only cause code listed in 3GPP TS 48.008 3.2.1.21 CLEAR COMMAND
+				 * that qualifies for a normal release situation. (OS#4664) */
+				.gsm0808_cause = GSM0808_CAUSE_CALL_CONTROL,
 				.csfb_ind = (vsub && vsub->sgs_fsm->state == SGS_UE_ST_ASSOCIATED),
 			},
 		};

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1347ed72ae7d7ea73a557b866e764819c5ef8c42
Gerrit-Change-Number: 19213
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/185cfd6d/attachment.htm>