Change in osmo-trx[master]: Transceiver: Fix race condition obtaining Dl burst from Upper layer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 10 16:51:16 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19206 )

Change subject: Transceiver: Fix race condition obtaining Dl burst from Upper layer
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/19206/3/Transceiver52M/radioVector.cpp 
File Transceiver52M/radioVector.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/19206/3/Transceiver52M/radioVector.cpp@121 
PS3, Line 121: getStaleBurst
> Might be worth to add a comment stating that these functions expect the lock/mutex to be acquired an […]
I thought about that, but tbh they are only used in one place and I doubt they'll ever be used anywhere else, so no real need, specially because the class only has those 2-3 functions.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If1fd8d7fc5f21ee2894192ef1ac2a3cdda6bbb98
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jul 2020 16:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/be7a3cff/attachment.htm>


More information about the gerrit-log mailing list