Change in osmo-mgw[master]: mgcp_trunk: remove double check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jul 10 13:29:09 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19119 )

Change subject: mgcp_trunk: remove double check
......................................................................


Patch Set 5:

(1 comment)

(ensure messages are sent)

https://gerrit.osmocom.org/c/osmo-mgw/+/19119/2/src/libosmo-mgcp/mgcp_trunk.c 
File src/libosmo-mgcp/mgcp_trunk.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/19119/2/src/libosmo-mgcp/mgcp_trunk.c@164 
PS2, Line 164: 		return mgcp_trunk_by_num(cfg, MGCP_TRUNK_E1, trunk_nr);
> It looks to me like now mgcp_trunk_by_name() no longer works for epname that contain the virtual tru […]
I think everything is ok here, also the TTCN3 tests pass fine. Do I miss anything?

If the virtual trunk is requested and the virtual trunk prefix is contained it should if in line 158 should become true, then we return the virtual trunk.

If the trunk is an E1, if in line 163 will become true and we return the E1 trunk.

The check below in line 174 if for legacy requests without trunk prefix. If non of the above applies it is the last chance to get a trunk. However, I would strongly argue to remove this part. Osmo-msc and osmo-bsc do the requests properly for a long time now.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I91fb8cf6e3b077ba8f18fdbcd071275c6fd7cacd
Gerrit-Change-Number: 19119
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jul 2020 13:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/36556fe5/attachment.htm>


More information about the gerrit-log mailing list