This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19118 ) Change subject: mgcp_endp: use define constant to define max number of E1 subslots ...................................................................... Patch Set 4: (3 comments) (ensure messages are sent) https://gerrit.osmocom.org/c/osmo-mgw/+/19118/2/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19118/2/src/libosmo-mgcp/mgcp_endp.c@527 PS2, Line 527: const int8_t interlock_tab[MGCP_ENDP_E1_SUBSLOTS][16] = > s/16/MGCP_ENDP_E1_SUBSLOTS + 1 […] 16 is wrong. When counting out the length of the row I see its only 15. However, using MGCP_ENDP_E1_SUBSLOTS there would be wrong either because it is by coincidence and does not really relate to the number of possible subslot combinations. https://gerrit.osmocom.org/c/osmo-mgw/+/19118/4/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19118/4/src/libosmo-mgcp/mgcp_endp.c@527 PS4, Line 527: 15 > Now you fixed it from 16 to 15, but I meant rather use the MGCP_ENDP_E1_SUBSLOTS constant here? […] 16 was wrong, its a 15x15 array. This bug was unrelated. However, the 16 I fixed to 15 is still unrelated to MGCP_ENDP_E1_SUBSLOTS https://gerrit.osmocom.org/c/osmo-mgw/+/19118/4/src/libosmo-mgcp/mgcp_endp.c@528 PS4, Line 528: { { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, -1 }, > Looking at it now, the alignment you use here is pretty weird. Simply move the first { up. I have fixed it in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If7cb74e486946aff09e22abf8a8885bf0693f34e Gerrit-Change-Number: 19118 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jul 2020 13:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/03b74e54/attachment.htm>