Change in osmo-trx[master]: Transceiver: Fix race condition obtaining Dl burst from Upper layer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jul 10 10:01:40 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19206 )

Change subject: Transceiver: Fix race condition obtaining Dl burst from Upper layer
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/19206/1/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/19206/1/Transceiver52M/Transceiver.cpp@a466 
PS1, Line 466: 
> I was reworking/refactoring the entire function as you can see, so with the new code blocks added it […]
What's wrong with this space? What problem this particular line solves?

This line is not related to your refactoring changes, and it's harder to read such mixed changes. Following this logic, everything in this file is related to your reworking/refactoring, so why don't you drop the other empty lines then (e.g. line#459)? Moreover, I think the opposite: this empty line makes the code easier to read, so it makes sense to you, but does not to me.

I don't want to block your work, but it's getting a trend that. Some day we may see this line re-introduced again because somebody else has different coding style preferences, and that would be a mess.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If1fd8d7fc5f21ee2894192ef1ac2a3cdda6bbb98
Gerrit-Change-Number: 19206
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jul 2020 10:01:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200710/d1df72bf/attachment.htm>


More information about the gerrit-log mailing list