Change in osmo-mgw[master]: mgcp_vty: be more specific about E1 trunks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 9 00:41:18 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19103 )

Change subject: mgcp_vty: be more specific about E1 trunks
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c@858 
PS6, Line 858:       "trunk e1 <1-64>", "Configure Trunk\n" "E1 trunk\n" "Trunk Nr\n")
do we need compatibility for old 'trunk <1-64>' command?


https://gerrit.osmocom.org/c/osmo-mgw/+/19103/6/src/libosmo-mgcp/mgcp_vty.c@897 
PS6, Line 897: 		vty_out(vty, " trunk-e1 %d%s", trunk->trunk_nr, VTY_NEWLINE);
above you wrote "trunk e1" so I doubt this can be parsed



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I22c39ee9a36e4e737992c91677f3e315907a4c7e
Gerrit-Change-Number: 19103
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 00:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/2bba48e9/attachment.htm>


More information about the gerrit-log mailing list