Change in osmo-pcu[master]: encoding: Encode TA as unsigned and check validty against GSM48_TA_IN...

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19176 )

Change subject: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2//COMMIT_MSG@7 
PS2, Line 7: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID
validity


https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2//COMMIT_MSG@12 
PS2, Line 12: here.ch we use everywhere else to initialize when the
            : value is not known.
?


https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2/src/encoding.cpp 
File src/encoding.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2/src/encoding.cpp@553 
PS2, Line 553: int8_t ta_idx
but this is still signed?


https://gerrit.osmocom.org/c/osmo-pcu/+/19176/2/src/encoding.cpp@583 
PS2, Line 583: ta_idx
and the signed gets passed as unsigned?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc
Gerrit-Change-Number: 19176
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 00:19:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/ef4c65dd/attachment.htm>