Change in osmocom-bb[master]: trxcon/scheduler: check TDMA frame order, drop out of order bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 9 00:11:40 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19201 )

Change subject: trxcon/scheduler: check TDMA frame order, drop out of order bursts
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/19201/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/19201/1//COMMIT_MSG@40 
PS1, Line 40: is to reject them and log an error.  Passing them the the logical
the the


https://gerrit.osmocom.org/c/osmocom-bb/+/19201/1/src/host/trxcon/sched_trx.c 
File src/host/trxcon/sched_trx.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/19201/1/src/host/trxcon/sched_trx.c@727 
PS1, Line 727: 					"than the last processed fn=%u => dropping...\n",
(the entire string put on the second line would be nicer; I'd drop the "...")

just a thought, if this happens regularly with multi trx, then maybe the ERROR log would be too aggressive?



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I873c8555ea2ca190b1689227bb0fdcba87188772
Gerrit-Change-Number: 19201
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 00:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/42186298/attachment.htm>


More information about the gerrit-log mailing list