Change in osmo-msc[master]: is_reset_msg: use proper enum for rc value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Jul 8 23:53:40 UTC 2020


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19129 )

Change subject: is_reset_msg: use proper enum for rc value
......................................................................

is_reset_msg: use proper enum for rc value

Change-Id: I88b6204bc3ffac06f92bfc87639ce503b2da24bc
---
M src/libmsc/ran_peer.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/ran_peer.c b/src/libmsc/ran_peer.c
index 80ce558..001dfb1 100644
--- a/src/libmsc/ran_peer.c
+++ b/src/libmsc/ran_peer.c
@@ -204,18 +204,18 @@
 	struct ran_peer *rp = fi->priv;
 	struct ran_peer_ev_ctx *ctx = data;
 	struct msgb *msg = ctx->msg;
-	int rc;
+	enum reset_msg_type is_reset;
 	int supports_osmux;
 
 	switch (event) {
 	case RAN_PEER_EV_MSG_UP_CL:
-		rc = rp->sri->ran->sccp_ran_ops.is_reset_msg(rp->sri, fi, msg, &supports_osmux);
+		is_reset = rp->sri->ran->sccp_ran_ops.is_reset_msg(rp->sri, fi, msg, &supports_osmux);
 		ran_peer_update_osmux_support(rp, supports_osmux);
-		switch (rc) {
-		case 1:
+		switch (is_reset) {
+		case SCCP_RAN_MSG_RESET:
 			osmo_fsm_inst_dispatch(fi, RAN_PEER_EV_RX_RESET, msg);
 			return;
-		case 2:
+		case SCCP_RAN_MSG_RESET_ACK:
 			osmo_fsm_inst_dispatch(fi, RAN_PEER_EV_RX_RESET_ACK, msg);
 			return;
 		default:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19129
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I88b6204bc3ffac06f92bfc87639ce503b2da24bc
Gerrit-Change-Number: 19129
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/76412fd4/attachment.htm>


More information about the gerrit-log mailing list