Change in osmo-pcu[master]: encoding: Encode TA as unsigned and check validty against GSM48_TA_IN...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jul 8 16:08:44 UTC 2020


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/19176

to look at the new patch set (#2).

Change subject: encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID
......................................................................

encoding: Encode TA as unsigned and check validty against GSM48_TA_INVALID

According to 3GPP TS 44.018 sec 10.5.2.40, Timing Advance value is 8 bit
and range is 0-63 (0-219 on GSM400). unsigned value (uint8_t) is used
everywhere else, so avoid using a signed one here, and simply check for
GSM48_TA_INVALID here.ch we use everywhere else to initialize when the
value is not known. Ideally we should check for value based on band.

Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc
---
M src/encoding.cpp
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/19176/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19176
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I82b13561d0fe5ebafb5c3a8b9a501045c29809bc
Gerrit-Change-Number: 19176
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/30b6e87d/attachment.htm>


More information about the gerrit-log mailing list