Change in osmo-gsm-tester[master]: enb_amarisoft: add option to enable and configure DL AWGN channel

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jul 8 12:18:53 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185 )

Change subject: enb_amarisoft: add option to enable and configure DL AWGN channel
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py 
File src/osmo_gsm_tester/obj/enb_amarisoft.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185/1/src/osmo_gsm_tester/obj/enb_amarisoft.py@164 
PS1, Line 164:         config.overlay(values, dict(enb={'dl_awgn_snr': values['enb'].get('dl_awgn_snr', 30)}))
Looks like you only really need to add 30 to defaults.conf and get rid of this line?
Same on the one above, add "false" in defaults.conf and get rid of the default part of get().

BTW, I don't know the details about those values, but it may make sense to completely remove enable_dl_awgn and enable/disable it based on a specific dl_awgn_snr, like -1 or -1000 or 0 or whatever.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib248e87e5abd855d4c974eab42ec40828c6e1d40
Gerrit-Change-Number: 19185
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Jul 2020 12:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/1cd436a9/attachment.htm>


More information about the gerrit-log mailing list