Change in osmocom-bb[master]: trxcon/scheduler: fix subst_frame_loss(): do not compensate too much

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 8 08:55:40 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19184 )


Change subject: trxcon/scheduler: fix subst_frame_loss(): do not compensate too much
......................................................................

trxcon/scheduler: fix subst_frame_loss(): do not compensate too much

It's not something that we should be trying to fix, if the whole
TDMA multi-frame is lost.  For some yet unknown reason, sometimes
the difference between the last processed TDMA frame number and
the current one is so huge, so trxcon eats a lot of CPU trying
to compensate nearly the whole TDMA hyper-frame:

  sched_trx.c:640 Too many (>104) contiguous TDMA frames elapsed (2715647)
                  since the last processed fn=633 (current fn=632)

Let's just print a warning and do not compensate more than one
TDMA multi-frame period corresponding to the current layout.

Change-Id: I56251d0d2f6fa19195ff105d3bdfbc22df6db8cd
---
M src/host/trxcon/sched_trx.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/19184/1

diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c
index 79e6f88..9195b33 100644
--- a/src/host/trxcon/sched_trx.c
+++ b/src/host/trxcon/sched_trx.c
@@ -640,6 +640,7 @@
 		LOGP(DSCHD, LOGL_NOTICE, "Too many (>%u) contiguous TDMA frames elapsed (%u) "
 					 "since the last processed fn=%u (current %u)\n",
 					 mf->period, elapsed, lchan->tdma.last_proc, fn);
+		return -EIO;
 	} else if (elapsed == 0) {
 		LOGP(DSCHD, LOGL_ERROR, "No TDMA frames elapsed since the last processed "
 					"fn=%u, must be a bug?\n", lchan->tdma.last_proc);

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I56251d0d2f6fa19195ff105d3bdfbc22df6db8cd
Gerrit-Change-Number: 19184
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/bd3f6c58/attachment.htm>


More information about the gerrit-log mailing list