Change in osmo-ttcn3-hacks[master]: library/GSM_RestOctets: add SI2quater EUTRAN templates

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114 )

Change subject: library/GSM_RestOctets: add SI2quater EUTRAN templates
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114/3/library/GSM_RestOctets.ttcn 
File library/GSM_RestOctets.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114/3/library/GSM_RestOctets.ttcn@523 
PS3, Line 523: meas_params_desc := { presence := '0'B, desc := omit },
             : 	gprs := {
             : 		rt_diff_desc := { presence := '0'B, desc := omit },
             : 		bsic_desc := { presence := '0'B, desc := omit },
             : 		rep_prio_desc := { presence := '0'B, desc := omit },
             : 		meas_params_desc := { presence := '0'B, desc := omit }
             : 	},
             : 	nc_meas_params := { presence := '0'B, params := omit },
             : 	ext_info := { presence := '0'B, info := omit },
             : 
             : 	utran_neigh_desc := { presence := '0'B, desc := omit },
             : 	utran_meas_params_desc := { presence := '0'B, desc := omit },
             : 	utran_gprs_meas_params_desc := { presence := '0'B, desc := omit },
Again, please do not copy-paste. Rather do 'modifies tro_SI2quaterRestOctets_base' and change what needs to be different from the base template.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114/3/library/GSM_RestOctets.ttcn@583 
PS3, Line 583: uint16_t e_arfcn := 111, uint3_t meas_bw := 3
These values are ttcn-bsc-test specific, while this file belongs to 'library'. Rather add template arguments, so this template would be much more flexible:

  template (present) uint16_t e_arfcn := ?,
  template (omit) uint3_t meas_bw := *


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114/3/library/GSM_RestOctets.ttcn@587 
PS3, Line 587: meas_bw_presence := '1'B,
             : 	meas_bw := meas_bw
So here you can do:

  meas_bw_presence := ?,
  meas_bw := meas_bw


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114/3/library/GSM_RestOctets.ttcn@595 
PS3, Line 595: uint5_t thresh_hi := 20
Same here: tr_* templates should allow matching against '?' and '*'.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4162cc39ad351f5e96f5941116a424adc44efaa2
Gerrit-Change-Number: 19114
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 08 Jul 2020 00:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/90158cba/attachment.htm>