This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19169 )
Change subject: libosmo-mgcp: fix unused extra argument to printf() in add_fmtp()
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> Can you explain a bit more why this unused. Is the filed never populated?
Well, the format string "\r\n" contains no format specifiers... It's like calling printf("Hello world\n", foo, bar).
https://gerrit.osmocom.org/c/osmo-mgw/+/19169/1/src/libosmo-mgcp/mgcp_sdp.c
File src/libosmo-mgcp/mgcp_sdp.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/19169/1/src/libosmo-mgcp/mgcp_sdp.c@480
PS1, Line 480: fmtp_params[i].payload_type
Looks like it was copy-pasted from here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19169
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie48da20aea7bc1eedc3f8b5b4a708458f0860a25
Gerrit-Change-Number: 19169
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jul 2020 16:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200707/db3b92b4/attachment.htm>