This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19121 )
Change subject: mgcp_vty: refactor endpoint number configuration
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c
File src/libosmo-mgcp/mgcp_trunk.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c@45
PS3, Line 45: trunk->virtual.vty_number_endpoints = 32;
: trunk->e1.vty_timeslot_first = 1;
: trunk->e1.vty_timeslot_num = 2;
I would not make this vty configurable. Having to synchronize your configuration files between BSC and MGW all the time becomes a nightmare from a maintenance/operations point of view.
I would hope that drivers like DAHDI and osmo-e1d doesn't permit opening the same timeslot multiple times at once? If they refuse to be opened multiple times, then osmo-mgw could simply try to open any timeslot, and return an error if it's already opened (Such as those used for Abis signaling).
If DAHDI actually permits opening the same TS multiple times, I suggest we introduce some kind of automatic locking mechanism. For example, osmo-bsc could write a file in /var/lib/osmocom/... which lines/files/.. it has opened and osmo-mgw then reads that file. But this is also "ugly" in a sense that it produces a lot of file I/O and we end up with the problem that libosmo-abis line numbers 0-255 are dynamically mapped (per vty config) to any driver + driver-specific line number, and those configs might not match on osmo-bsc + osmo-mgw.
For now, I would simply trust that osmo-bsc is not sending invalid (signaling) timeslotss in endpoint names to osmo-mgw.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77
Gerrit-Change-Number: 19121
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 06 Jul 2020 19:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/b0629b3f/attachment.htm>