This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19107 ) Change subject: bts-trx: Introduce rate counter for scheduler timerfd missed FNs ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h@57 PS1, Line 57: /* bts-trx specific rate counters */ > We should drop all comments containing "osmo-bts-trx" then? or what? It's already there 3 lines abov […] Ideally, there should be no such comments every three lines in a directory/file/structure that is all about osmo-bts-trx. Otherwise it raises a question like: is there anything e.g. sysmo-bts specific in this file/structure? I also don't see a problem, neither I am blocking this change with CR-1. It's just a cosmetic comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0051b9ab18ebc9f92db11374d856de94f155efa4 Gerrit-Change-Number: 19107 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 05 Jul 2020 17:31:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200705/0ccb2398/attachment.htm>