This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgHello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19102 to look at the new patch set (#4). Change subject: mgcp_trunk: pick trunk by number and type ...................................................................... mgcp_trunk: pick trunk by number and type The function mgcp_trunk_by_num() is used to directly pick a specific trunk that is known by its id number (sometimes called "index"). Traditionally the virtual trunk will reside under id number 0 and all consecutively created E1 trunks will be created under number 1 to 64. This works fine, but puts a limitation on us should we ever introduce an aditional trunk type (e.g. T1). Since the numbers must be unique regardless of the trunk type one could not have an E1 trunk number 1 and e.g. a T1 trunk number 1 at the same time. So we should pick the trunk not only by its number, but also by its type to allow different trunk types to carry the same number. The trunks will still be distinguishable by its type along with the respective endpoint prefix. Change-Id: I7af1e9ce601babd4a51e88201a98319e03945f83 Related: OS#2659 --- M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 5 files changed, 49 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/02/19102/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7af1e9ce601babd4a51e88201a98319e03945f83 Gerrit-Change-Number: 19102 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200704/24a0d28b/attachment.htm>