Change in osmo-ttcn3-hacks[master]: msc: verify conn and VLR cell id in most tests

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998 )

Change subject: msc: verify conn and VLR cell id in most tests
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn@62 
PS1, Line 62: import from TCCConversion_Functions { function f_strstr };
> oh I thought last discussion we had about this concluded this partial including was not supported in […]
I found this in some ttcn3 explaining PDF,
but vadim already told me that partial includes all amount to "all" anyway.
I thought it would be nice to indicate why I'm including this file, but if you insist we can make it 'all'


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn@370 
PS1, Line 370: 	f_verify_vty_lac_ci(verify_vlr := false);
> In general I'm for testing stuff in general for all tests, but I'm not really sure we want to run st […]
I didn't see a noticeable change in time the tests take to run. The VTY request and analysis of response is pretty instantaneous AFAICT. Are you having a different experience?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/MSC_Tests.ttcn 
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/MSC_Tests.ttcn@411 
PS1, Line 411: 		verify_cell_id := mp_enable_cell_id_test and verify_cell_id
> So you are actualyl doing what I requested, but you are not checking the var in all places where the […]
I'm not following, doing what you requested??



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie410714a96353f74a52a104c56fa0a08683e0004
Gerrit-Change-Number: 18998
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Jul 2020 23:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200703/4ae320e3/attachment.htm>