Change in osmo-mgw[master]: trunk: parse E1 trunk number

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18752 )

Change subject: trunk: parse E1 trunk number
......................................................................


Patch Set 12:

(3 comments)

(ensure that all comments are sent)

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/8/src/libosmo-mgcp/mgcp_trunk.c 
File src/libosmo-mgcp/mgcp_trunk.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/8/src/libosmo-mgcp/mgcp_trunk.c@145 
PS8, Line 145: epname + prefix_len == str_trunk_nr_end
> Now I finally understand, you want the delimiter to be checked...
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/18752/10/tests/mgcp/mgcp_test.c 
File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/10/tests/mgcp/mgcp_test.c@2138 
PS10, Line 2138: 	 * the trunk number. Since the prefix has a fixt length, only
> fixed
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/18752/11/tests/mgcp/mgcp_test.c 
File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/11/tests/mgcp/mgcp_test.c@2144 
PS11, Line 2144: trunk_nr = e1_trunk_nr_from_epname("ds/e1+2/s-1/su16-0");
               : 	OSMO_ASSERT(trunk_nr == 2);
               : 	trunk_nr = e1_trunk_nr_from_epname("xxxxxx3/s-1/su16-0");
               : 	OSMO_ASSERT(trunk_nr == 3);
               : 	trunk_nr = e1_trunk_nr_from_epname("xxxxxx4/zz");
               : 	OSMO_ASSERT(trunk_nr == 4);
> I really don't want to delay this patch any longer, but to me it doesn't make sense that we ignore t […]
I have changed the code a bit, now the check s in that function. I also think that this is better.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2020 13:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200702/b9979b7c/attachment.htm>