Change in osmo-gsm-tester[master]: test: append KPI rather than overwrite in set_kpi() method

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Wed Jul 1 09:50:22 UTC 2020


srs_andre has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18988 )

Change subject: test: append KPI rather than overwrite in set_kpi() method
......................................................................

test: append KPI rather than overwrite in set_kpi() method

this allows to call set_kpi() multiple times in one TC

Change-Id: I5f68d9e6e1135ee2afa79c9af2ed240d371214c4
---
M src/osmo_gsm_tester/core/test.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/core/test.py b/src/osmo_gsm_tester/core/test.py
index dfbd169..fd3ac04 100644
--- a/src/osmo_gsm_tester/core/test.py
+++ b/src/osmo_gsm_tester/core/test.py
@@ -143,7 +143,10 @@
     def set_kpis(self, kpis):
         if not isinstance(kpis, dict):
             raise log.Error('Expected dictionary in toplevel kpis')
-        self._kpis = kpis
+        if isinstance(self._kpis, dict):
+            self._kpis.update(kpis)
+        else:
+            self._kpis = kpis
 
     def kpis(self):
         return self._kpis

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5f68d9e6e1135ee2afa79c9af2ed240d371214c4
Gerrit-Change-Number: 18988
Gerrit-PatchSet: 4
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200701/998f863c/attachment.htm>


More information about the gerrit-log mailing list