Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 )

Change subject: mdns_rfc.c: fix possible access of uninit. mem
......................................................................

mdns_rfc.c: fix possible access of uninit. mem

Fixes: CID#207548
Change-Id: Ifa269d8a88d84c01349668cdd8d1f1d24c12c6d8
---
M src/mslookup/mdns_rfc.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/mslookup/mdns_rfc.c b/src/mslookup/mdns_rfc.c
index e1fc184..6f39a8e 100644
--- a/src/mslookup/mdns_rfc.c
+++ b/src/mslookup/mdns_rfc.c
@@ -83,7 +83,12 @@
 		return NULL;
 
 	while (*qname) {
-		size_t len = *qname;
+		size_t len;
+
+		if (i >= qname_max_len)
+			return NULL;
+
+		len = *qname;
 		next_label = qname + len + 1;
 
 		if (next_label >= qname_end || i + len > OSMO_MDNS_RFC_MAX_NAME_LEN)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ifa269d8a88d84c01349668cdd8d1f1d24c12c6d8
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200131/6b412224/attachment.htm>