Change in osmo-ccid-firmware[master]: git version appended to the product usb string descriptor

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 31 15:18:38 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035 )

Change subject: git version appended to the product usb string descriptor
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035/3/sysmoOCTSIM/main.c 
File sysmoOCTSIM/main.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035/3/sysmoOCTSIM/main.c@454 
PS3, Line 454: char product_buf[] = "sysmoOCTSIM "GIT_VERSION;
could be const (and hence in flash/rom)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I4a9d010c9025cf8c14ebaf42de048b9a172c7786
Gerrit-Change-Number: 17035
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 31 Jan 2020 15:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200131/ab7c0d1d/attachment.htm>


More information about the gerrit-log mailing list