Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: add f_enc_IPv4

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17063 )

Change subject: library/DNS_Helpers: add f_enc_IPv4
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17063/2/library/DNS_Helpers.ttcn 
File library/DNS_Helpers.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17063/2/library/DNS_Helpers.ttcn@73 
PS2, Line 73: function f_enc_IPv4(charstring str) return octetstring {
I would normally give the function either a more descriptive name (linking it to something DNS specific) and/or mark it private.  With that generic name, it is likely that other modules might implement a f_enc_IPv4, too, leading to namespace conflict warnings



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8a5450988711680c93cfd657a34db759a56bc41e
Gerrit-Change-Number: 17063
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 31 Jan 2020 15:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200131/c7e0e819/attachment.htm>