Change in osmo-asf4-dfu[master]: usb serial number descriptor

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Wed Jan 29 10:43:35 UTC 2020


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 )

Change subject: usb serial number descriptor
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c 
File usb_start.c:

https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c@121 
PS2, Line 121: SYSMOOCTSIM
> why have this specifically to SYSMOOCTSIM?  I think this is a generic feature that should work for a […]
I wanted to have something that works with the current octsim, the string index depends on the actual descriptor layout. It could be argued that quite a bit of code is shared between the bootloader and the firmware so it should be put into some sort of common shared code/lib, but there are currently more important issues.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I4a23682cee0849c788e5f6c611df4ed1f1cac3da
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 29 Jan 2020 10:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200129/dfe3eb7b/attachment.htm>


More information about the gerrit-log mailing list