This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 ) Change subject: usb serial number descriptor ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024/2/usb_start.c@121 PS2, Line 121: SYSMOOCTSIM why have this specifically to SYSMOOCTSIM? I think this is a generic feature that should work for all boards based on the same chip, actually possibly even for all boards using the same family of chips? So I would say the proper way to introduce this is to have a chip-specific HAVE_CHIP_UNIQUE_ID or so, and then provide a chip-specific library function to obtain that unique number, which can be used here? Doesn't sound like all that much effort, and will help us with the next board using this codebase. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I4a23682cee0849c788e5f6c611df4ed1f1cac3da Gerrit-Change-Number: 17024 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 28 Jan 2020 21:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200128/778205c2/attachment.htm>