Change in osmo-msc[master]: libmsc/gsm_04_11.h: remove unused sms_deliver definition

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/17023 )


Change subject: libmsc/gsm_04_11.h: remove unused sms_deliver definition
......................................................................

libmsc/gsm_04_11.h: remove unused sms_deliver definition

This structure is never used in the code, and moreover cannot be
used to parse a SUBMIT message correctly at least because:

  - it is not cross-platform and will only work on LSB machines;
  - it is not marked as 'packed', so there can be padding;
  - TP-SRR and TP-RP are swapped (questionable).

P.S. 3GPP TS 23.040, section 9.2.2.1 is not clear about the field
     ordering. In the table listing basic elements [1] they define
     the present order, while in the layout table [2] it's reversed:

       [1] TP-MTI, TP-MMS, TP-LP, TP-SRI, TP-UDHI, TP-RP

     vs

       [2] TP-MTI, TP-MMS, TP-LP, TP-RP, TP-UDHI, TP-SRI

Change-Id: Icd4b0c45d994dd02d9118890eb5a1261a2008eca
---
M include/osmocom/msc/gsm_04_11.h
1 file changed, 0 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/23/17023/1

diff --git a/include/osmocom/msc/gsm_04_11.h b/include/osmocom/msc/gsm_04_11.h
index c504c7f..19aaa3a 100644
--- a/include/osmocom/msc/gsm_04_11.h
+++ b/include/osmocom/msc/gsm_04_11.h
@@ -11,24 +11,6 @@
 
 #define UM_SAPI_SMS 3	/* See GSM 04.05/04.06 */
 
-/* SMS deliver PDU */
-struct sms_deliver {
-	uint8_t mti:2;		/* message type indicator */
-	uint8_t mms:1;		/* more messages to send */
-	uint8_t rp:1;		/* reply path */
-	uint8_t udhi:1;	/* user data header indicator */
-	uint8_t sri:1;		/* status report indication */
-	uint8_t *orig_addr;	/* originating address */
-	uint8_t pid;		/* protocol identifier */
-	uint8_t dcs;		/* data coding scheme */
-				/* service centre time stamp */
-	uint8_t ud_len;	/* user data length */
-	uint8_t *user_data;	/* user data */
-
-	uint8_t msg_ref;	/* message reference */
-	uint8_t *smsc;
-};
-
 struct gsm_network;
 struct msgb;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icd4b0c45d994dd02d9118890eb5a1261a2008eca
Gerrit-Change-Number: 17023
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200127/9c21c4c3/attachment.htm>